This patchset removes all RT_TRACE usages left and definitions The whole private tracing system is not tied to a configuration symbol and the default behaviour is _trace nothing_. It's verbose and relies on a private log level tracing doomed to be removed. The patchset consist on a first patch applying the following semantic patch on rtl8723bs directory: $ cat RT_TRACE.cocci @@ expression a, b, c; @@ - RT_TRACE(a, b, (c)); Then follows a patch removing commented out RT_TRACE calls. Third patch removes RT_TRACE definitions. All other patches, do some code cleaning on sites left blank by RT_TRACE removal. This scheme was suggested by Joe Perches. https://lore.kernel.org/linux-staging/1cd79d781cdcccf621ce8e104a9cdf1e90e7f803.camel@xxxxxxxxxxx/ Fabio Aiuto (10): staging: rtl8723bs: remove all RT_TRACE logs in hal/ and os_dep/ staging: rtl8723bs: remove commented out RT_TRACE logs in hal/ and os_dep/ staging: rtl8723bs: remove RT_TRACE log definitions staging: rtl8723bs: remove empty if, else blocks after RT_TRACE deletion staging: rtl8723bs: remove empty #ifdef blocks after RT_TRACE deletion staging: rtl8723bs: remove unnecessary bracks after RT_TRACE deletion staging: rtl8723bs: place constant on the right side of the test staging: rtl8723bs: rewrite comparisons to null staging: rtl8723bs: remove empty for cycles staging: rtl8723bs: remove commented code block .../staging/rtl8723bs/hal/HalPhyRf_8723B.c | 3 - drivers/staging/rtl8723bs/hal/HalPwrSeqCmd.c | 46 ------ .../staging/rtl8723bs/hal/hal_com_phycfg.c | 20 --- drivers/staging/rtl8723bs/hal/hal_intf.c | 2 - .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 131 +----------------- .../staging/rtl8723bs/hal/rtl8723b_phycfg.c | 33 ----- .../staging/rtl8723bs/hal/rtl8723b_rf6052.c | 2 - .../staging/rtl8723bs/hal/rtl8723bs_recv.c | 5 +- .../staging/rtl8723bs/hal/rtl8723bs_xmit.c | 41 +----- drivers/staging/rtl8723bs/hal/sdio_halinit.c | 49 +------ drivers/staging/rtl8723bs/hal/sdio_ops.c | 35 +---- drivers/staging/rtl8723bs/include/rtw_debug.h | 18 --- .../staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 6 - .../staging/rtl8723bs/os_dep/ioctl_linux.c | 69 +-------- drivers/staging/rtl8723bs/os_dep/mlme_linux.c | 4 - drivers/staging/rtl8723bs/os_dep/os_intfs.c | 52 +------ .../staging/rtl8723bs/os_dep/osdep_service.c | 4 +- drivers/staging/rtl8723bs/os_dep/recv_linux.c | 12 +- drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 28 +--- drivers/staging/rtl8723bs/os_dep/xmit_linux.c | 5 - 20 files changed, 24 insertions(+), 541 deletions(-) -- 2.20.1