On Sat, Apr 03, 2021 at 11:13:38AM +0200, Fabio Aiuto wrote: > the RT_TRACE() output is not useful so we want to delete it. In this case > there is no cleanup for rtw_cleanbss_cmd() required or even possible. I've > deleted the RT_TRACE() output and added a goto unlock to show > that we can't continue if rtw_createbss_cmd() fails. > > Suggested-by: David Carpenter <dan.carpenter@xxxxxxxxxx> > Signed-off-by: Fabio Aiuto <fabioaiuto83@xxxxxxxxx> > --- > drivers/staging/rtl8723bs/core/rtw_mlme.c | 17 +++++++++++------ > 1 file changed, 11 insertions(+), 6 deletions(-) Hi Dan, I put a Suggested-by tag on one patch in v3 patchset. But reading the docs on submitting patches I relaized later that maybe it requires your permission before. It' written about Reviewed-by but not about Suggested-by, should I have asked you before, should I? I'm sorry if I should have. thank you, fabio
