Re: [PATCH] bcm2835-pcm: Allow up to 8 channels and 192kHz data rate

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

Am 02.04.21 um 16:33 schrieb Greg Kroah-Hartman:
> On Fri, Apr 02, 2021 at 04:28:08PM +0200, Stefan Wahren wrote:
>> From: Dom Cobley <popcornmix@xxxxxxxxx>
>>
>> The firmware driver can support this, so allow it to be selected
>> Increase the buffer sizes to handle the higher data rates.
>>
>> Signed-off-by: Dom Cobley <popcornmix@xxxxxxxxx>
>> Signed-off-by: Stefan Wahren <stefan.wahren@xxxxxxxx>
>> ---
>>  drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c | 10 +++++-----
>>  1 file changed, 5 insertions(+), 5 deletions(-)
> Why are we adding new features to this code instead of working to get it
> out of staging?
>
> What is left to do here, it should have been cleaned up and long gone...

i agree with you regarding the driver. I'm not that audio expert and
aware of the TODOs.

I just wanted to adjust the "driver parameter".

>
> thanks,
>
> greg k-h






[Index of Archives]     [Linux Driver Development]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux