Re: [PATCH -next 6/6] staging: rtl8723bs: sta_mgt: return _FAIL if there is an error

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Mar 26, 2021 at 06:17:36PM -0600, Edmundo Carmona Antoranz wrote:
> If there is an error when calling rtw_init_bcmc_stainfo() inside
> rtw_init_bcmc_stainfo(), variable res is set to _FAIL. However, when
> returning, _SUCCESS is always returned regardless. Just in case,
> all existing calls do not consider the result of the function.

This more papering over badness.  Lets leave it as-is until someone can
fix the callers.  Static checkers are useful things but if we silence
the warnings without fixing the bugs then we are basically going to
great effort to write a checker and even more effort to disable the
checker.

regards,
dan carpenter





[Index of Archives]     [Linux Driver Development]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux