Re: [bug report] staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_INTERRUPT_BASED_TXBCN*

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Mar 25, 2021 at 11:56:40AM +0300, Dan Carpenter wrote:
> Hello Fabio Aiuto,
> 
> The patch 65f183001f6e: "staging: rtl8723bs: remove unused code
> blocks conditioned by never set CONFIG_INTERRUPT_BASED_TXBCN*" from
> Mar 16, 2021, leads to the following static checker warning:
> 
> 	drivers/staging/rtl8723bs/core/rtw_ap.c:911 start_bss_network()
> 	warn: inconsistent indenting
> 
> drivers/staging/rtl8723bs/core/rtw_ap.c
>    904                  rtw_get_capability((struct wlan_bssid_ex *)pnetwork)
>    905          );
>    906  
>    907          if (pmlmeext->bstart_bss) {
>    908                  update_beacon(padapter, WLAN_EID_TIM, NULL, true);
>    909  
>    910          /* issue beacon frame */
> 
> The patch accidentally deleted these extra tab for this block.
> 
>    911          if (send_beacon(padapter) == _FAIL)
>    912                  DBG_871X("issue_beacon, fail!\n");
>    913  
>    914          }
>    915  
>    916          /* update bc/mc sta_info */
>    917          update_bmc_sta(padapter);
>    918  
> 
> regards,
> dan carpenter

Thank you Dan,

sent yesterday a fix,

sorry for late,

fabio




[Index of Archives]     [Linux Driver Development]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux