Re: (subset) [PATCH v3 00/16] Converge on using secs_to_jiffies() part two
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: (subset) [PATCH v3 00/16] Converge on using secs_to_jiffies() part two
- From: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
- Date: Mon, 10 Mar 2025 19:08:03 -0700
- Cc: Yaron Avizrat <yaron.avizrat@xxxxxxxxx>, Oded Gabbay <ogabbay@xxxxxxxxxx>, Julia Lawall <Julia.Lawall@xxxxxxxx>, Nicolas Palix <nicolas.palix@xxxxxxx>, James Smart <james.smart@xxxxxxxxxxxx>, Dick Kennedy <dick.kennedy@xxxxxxxxxxxx>, "James E.J. Bottomley" <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx>, Jaroslav Kysela <perex@xxxxxxxx>, Takashi Iwai <tiwai@xxxxxxxx>, Chris Mason <clm@xxxxxx>, Josef Bacik <josef@xxxxxxxxxxxxxx>, David Sterba <dsterba@xxxxxxxx>, Ilya Dryomov <idryomov@xxxxxxxxx>, Dongsheng Yang <dongsheng.yang@xxxxxxxxxxxx>, Jens Axboe <axboe@xxxxxxxxx>, Xiubo Li <xiubli@xxxxxxxxxx>, Damien Le Moal <dlemoal@xxxxxxxxxx>, Niklas Cassel <cassel@xxxxxxxxxx>, Carlos Maiolino <cem@xxxxxxxxxx>, "Darrick J. Wong" <djwong@xxxxxxxxxx>, Sebastian Reichel <sre@xxxxxxxxxx>, Keith Busch <kbusch@xxxxxxxxxx>, Christoph Hellwig <hch@xxxxxx>, Sagi Grimberg <sagi@xxxxxxxxxxx>, Frank Li <Frank.Li@xxxxxxx>, Mark Brown <broonie@xxxxxxxxxx>, Shawn Guo <shawnguo@xxxxxxxxxx>, Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>, Pengutronix Kernel Team <kernel@xxxxxxxxxxxxxx>, Fabio Estevam <festevam@xxxxxxxxx>, Shyam Sundar S K <Shyam-sundar.S-k@xxxxxxx>, Hans de Goede <hdegoede@xxxxxxxxxx>, Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>, Henrique de Moraes Holschuh <hmh@xxxxxxxxxx>, Selvin Xavier <selvin.xavier@xxxxxxxxxxxx>, Kalesh AP <kalesh-anakkur.purayil@xxxxxxxxxxxx>, Jason Gunthorpe <jgg@xxxxxxxx>, Leon Romanovsky <leon@xxxxxxxxxx>, Easwar Hariharan <eahariha@xxxxxxxxxxxxxxxxxxx>, cocci@xxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, dri-devel@xxxxxxxxxxxxxxxxxxxxx, linux-sound@xxxxxxxxxxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx, ceph-devel@xxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, linux-ide@xxxxxxxxxxxxxxx, linux-xfs@xxxxxxxxxxxxxxx, linux-pm@xxxxxxxxxxxxxxx, linux-nvme@xxxxxxxxxxxxxxxxxxx, linux-spi@xxxxxxxxxxxxxxx, imx@xxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, platform-driver-x86@xxxxxxxxxxxxxxx, ibm-acpi-devel@xxxxxxxxxxxxxxxxxxxxx, linux-rdma@xxxxxxxxxxxxxxx, Takashi Iwai <tiwai@xxxxxxx>, Carlos Maiolino <cmaiolino@xxxxxxxxxx>
- In-reply-to: <174165504986.528513.3575505677065987375.b4-ty@oracle.com>
- References: <20250225-converge-secs-to-jiffies-part-two-v3-0-a43967e36c88@linux.microsoft.com> <174165504986.528513.3575505677065987375.b4-ty@oracle.com>
On Mon, 10 Mar 2025 21:19:03 -0400 "Martin K. Petersen" <martin.petersen@xxxxxxxxxx> wrote:
> On Tue, 25 Feb 2025 20:17:14 +0000, Easwar Hariharan wrote:
>
> > This is the second series (part 1*) that converts users of msecs_to_jiffies() that
> > either use the multiply pattern of either of:
> > - msecs_to_jiffies(N*1000) or
> > - msecs_to_jiffies(N*MSEC_PER_SEC)
> >
> > where N is a constant or an expression, to avoid the multiplication.
> >
> > [...]
>
> Applied to 6.15/scsi-queue, thanks!
>
> [02/16] scsi: lpfc: convert timeouts to secs_to_jiffies()
> https://git.kernel.org/mkp/scsi/c/a131f20804d6
Really, an acked-by would have been much easier all around, but whatever.
Did you get my fix?
From: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
Subject: scsi-lpfc-convert-timeouts-to-secs_to_jiffies-fix
Date: Tue Feb 25 07:32:03 PM PST 2025
fix build
Cc: Easwar Hariharan <eahariha@xxxxxxxxxxxxxxxxxxx>
Cc: James Bottomley <james.bottomley@xxxxxxxxxxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
drivers/scsi/lpfc/lpfc_sli.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/scsi/lpfc/lpfc_sli.c~scsi-lpfc-convert-timeouts-to-secs_to_jiffies-fix
+++ a/drivers/scsi/lpfc/lpfc_sli.c
@@ -3954,7 +3954,7 @@ void lpfc_poll_eratt(struct timer_list *
else
/* Restart the timer for next eratt poll */
mod_timer(&phba->eratt_poll,
- jiffies + secs_to_jiffies(phba->eratt_poll_interval);
+ jiffies + secs_to_jiffies(phba->eratt_poll_interval));
return;
}
_
[Index of Archives]
[Linux Kernel]
[Linux ARM (vger)]
[Linux ARM MSM]
[Linux Omap]
[Linux Arm]
[Linux Tegra]
[Fedora ARM]
[Linux for Samsung SOC]
[eCos]
[Linux Fastboot]
[Gcc Help]
[Git]
[DCCP]
[IETF Announce]
[Security]
[Linux MIPS]
[Yosemite Campsites]
|