The print function dev_err() is redundant because platform_get_irq() already prints an error. ./drivers/spi/spi-stm32-ospi.c:798:2-9: line 798 is redundant because platform_get_irq() already prints an error. Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=19220 Signed-off-by: Jiapeng Chong <jiapeng.chong@xxxxxxxxxxxxxxxxx> --- drivers/spi/spi-stm32-ospi.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/spi/spi-stm32-ospi.c b/drivers/spi/spi-stm32-ospi.c index 8eadcb64f34a..114ebb1516d4 100644 --- a/drivers/spi/spi-stm32-ospi.c +++ b/drivers/spi/spi-stm32-ospi.c @@ -794,10 +794,8 @@ static int stm32_ospi_get_resources(struct platform_device *pdev) } ospi->irq = platform_get_irq(pdev, 0); - if (ospi->irq < 0) { - dev_err(dev, "Can't get irq %d\n", ospi->irq); + if (ospi->irq < 0) return ospi->irq; - } ret = devm_request_irq(dev, ospi->irq, stm32_ospi_irq, 0, dev_name(dev), ospi); -- 2.32.0.3.g01195cf9f