Re: [PATCH v3 5/9] dt-bindings: serial: document qcom,gsi-dma-allowed

[Krzysztof Kozlowski <krzk@xxxxxxxxxx>]

On Mon, Mar 03, 2025 at 06:13:45PM +0530, Viken Dadhaniya wrote:
> Data transfer mode is fixed by TrustZone (TZ), which currently restricts
> developers from modifying the transfer mode from the APPS side.
> 
> Document the 'qcom,gsi-dma-allowed' property to select the data transfer
> mode to GPI DMA (Generic Packet Interface). If not set, FIFO mode
> (PIO/CPU DMA) will be selected by default.
> 
> Co-developed-by: Mukesh Kumar Savaliya <quic_msavaliy@xxxxxxxxxxx>
> Signed-off-by: Mukesh Kumar Savaliya <quic_msavaliy@xxxxxxxxxxx>
> Signed-off-by: Viken Dadhaniya <quic_vdadhani@xxxxxxxxxxx>
> ---
> v2 -> v3:

Missing dependency.

> 
> - Drop the 'qcom,xfer-mode' property and add the 'qcom,gsi-dma-allowed' property.
> - Add a reference for the QUP peripheral shared YAML.
> - Update commit log.
> 
> v2 Link: https://lore.kernel.org/linux-arm-msm/20250124105309.295769-5-quic_vdadhani@xxxxxxxxxxx/
> 
> v1 -> v2:
> 
> - Drop 'qcom,load-firmware' property and add 'firmware-name' property in
>   qup common driver.
> - Update commit log.
> 
> v1 Link: https://lore.kernel.org/linux-kernel/20241204150326.1470749-4-quic_vdadhani@xxxxxxxxxxx/
> ---
> ---
>  .../devicetree/bindings/serial/qcom,serial-geni-qcom.yaml      | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/serial/qcom,serial-geni-qcom.yaml b/Documentation/devicetree/bindings/serial/qcom,serial-geni-qcom.yaml
> index dd33794b3534..254fab9f2341 100644
> --- a/Documentation/devicetree/bindings/serial/qcom,serial-geni-qcom.yaml
> +++ b/Documentation/devicetree/bindings/serial/qcom,serial-geni-qcom.yaml
> @@ -12,6 +12,7 @@ maintainers:
>  
>  allOf:
>    - $ref: /schemas/serial/serial.yaml#
> +  - $ref: /schemas/soc/qcom/qcom,se-common-props.yaml#
>  
>  properties:
>    compatible:
> @@ -53,6 +54,8 @@ properties:
>    power-domains:
>      maxItems: 1
>  
> +  qcom,gsi-dma-allowed: true

And this also should be investigated, just like for I2C and SPI.

Best regards,
Krzysztof