On 1/28/2025 9:21 PM, Christoph Hellwig wrote: > On Tue, Jan 28, 2025 at 06:21:54PM +0000, Easwar Hariharan wrote: >> else >> - cfg->retry_timeout = msecs_to_jiffies( >> - init[i].retry_timeout * MSEC_PER_SEC); >> + cfg->retry_timeout = secs_to_jiffies(init[i].retry_timeout); > > This messes up the formatting by introducing an overly long line. > > Otherwise the change looks fine. I'll fix this in v2. Thanks for the review! - Easwar (he/him)
Re: [PATCH 09/16] xfs: convert timeouts to secs_to_jiffies()
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH 09/16] xfs: convert timeouts to secs_to_jiffies()
- From: Easwar Hariharan <eahariha@xxxxxxxxxxxxxxxxxxx>
- Date: Wed, 29 Jan 2025 09:12:53 -0800
- Cc: eahariha@xxxxxxxxxxxxxxxxxxx, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Yaron Avizrat <yaron.avizrat@xxxxxxxxx>, Oded Gabbay <ogabbay@xxxxxxxxxx>, Julia Lawall <Julia.Lawall@xxxxxxxx>, Nicolas Palix <nicolas.palix@xxxxxxx>, James Smart <james.smart@xxxxxxxxxxxx>, Dick Kennedy <dick.kennedy@xxxxxxxxxxxx>, "James E.J. Bottomley" <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx>, "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>, Jaroslav Kysela <perex@xxxxxxxx>, Takashi Iwai <tiwai@xxxxxxxx>, Chris Mason <clm@xxxxxx>, Josef Bacik <josef@xxxxxxxxxxxxxx>, David Sterba <dsterba@xxxxxxxx>, Ilya Dryomov <idryomov@xxxxxxxxx>, Dongsheng Yang <dongsheng.yang@xxxxxxxxxxxx>, Jens Axboe <axboe@xxxxxxxxx>, Xiubo Li <xiubli@xxxxxxxxxx>, Damien Le Moal <dlemoal@xxxxxxxxxx>, Niklas Cassel <cassel@xxxxxxxxxx>, Carlos Maiolino <cem@xxxxxxxxxx>, "Darrick J. Wong" <djwong@xxxxxxxxxx>, Sebastian Reichel <sre@xxxxxxxxxx>, Keith Busch <kbusch@xxxxxxxxxx>, Sagi Grimberg <sagi@xxxxxxxxxxx>, Frank Li <Frank.Li@xxxxxxx>, Mark Brown <broonie@xxxxxxxxxx>, Shawn Guo <shawnguo@xxxxxxxxxx>, Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>, Pengutronix Kernel Team <kernel@xxxxxxxxxxxxxx>, Fabio Estevam <festevam@xxxxxxxxx>, Shyam Sundar S K <Shyam-sundar.S-k@xxxxxxx>, Hans de Goede <hdegoede@xxxxxxxxxx>, Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>, Henrique de Moraes Holschuh <hmh@xxxxxxxxxx>, Selvin Xavier <selvin.xavier@xxxxxxxxxxxx>, Kalesh AP <kalesh-anakkur.purayil@xxxxxxxxxxxx>, Jason Gunthorpe <jgg@xxxxxxxx>, Leon Romanovsky <leon@xxxxxxxxxx>, cocci@xxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, dri-devel@xxxxxxxxxxxxxxxxxxxxx, linux-sound@xxxxxxxxxxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx, ceph-devel@xxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, linux-ide@xxxxxxxxxxxxxxx, linux-xfs@xxxxxxxxxxxxxxx, linux-pm@xxxxxxxxxxxxxxx, linux-nvme@xxxxxxxxxxxxxxxxxxx, linux-spi@xxxxxxxxxxxxxxx, imx@xxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, platform-driver-x86@xxxxxxxxxxxxxxx, ibm-acpi-devel@xxxxxxxxxxxxxxxxxxxxx, linux-rdma@xxxxxxxxxxxxxxx
- In-reply-to: <20250129052108.GB28513@lst.de>
- References: <20250128-converge-secs-to-jiffies-part-two-v1-0-9a6ecf0b2308@linux.microsoft.com> <20250128-converge-secs-to-jiffies-part-two-v1-9-9a6ecf0b2308@linux.microsoft.com> <20250129052108.GB28513@lst.de>
- User-agent: Mozilla Thunderbird
- Follow-Ups:
- Re: [PATCH 09/16] xfs: convert timeouts to secs_to_jiffies()
- From: Easwar Hariharan
- Re: [PATCH 09/16] xfs: convert timeouts to secs_to_jiffies()
- References:
- [PATCH 00/16] Converge on using secs_to_jiffies() part two
- From: Easwar Hariharan
- [PATCH 09/16] xfs: convert timeouts to secs_to_jiffies()
- From: Easwar Hariharan
- Re: [PATCH 09/16] xfs: convert timeouts to secs_to_jiffies()
- From: Christoph Hellwig
- [PATCH 00/16] Converge on using secs_to_jiffies() part two
- Prev by Date: Re: [PATCH 14/16] platform/x86/amd/pmf: convert timeouts to secs_to_jiffies()
- Next by Date: Re: [PATCH 08/16] libata: zpodd: convert timeouts to secs_to_jiffies()
- Previous by thread: Re: [PATCH 09/16] xfs: convert timeouts to secs_to_jiffies()
- Next by thread: Re: [PATCH 09/16] xfs: convert timeouts to secs_to_jiffies()
- Index(es):
 |