Re: [PATCH] spi: amd: Fix -Wuninitialized in amd_spi_exec_mem_op()

[Miquel Raynal <miquel.raynal@xxxxxxxxxxx>]

Hello,

On 11/01/2025 at 12:08:38 -07, Nathan Chancellor <nathan@xxxxxxxxxx> wrote:

> After commit e6204f39fe3a ("spi: amd: Drop redundant check"), clang warns (or
> errors with CONFIG_WERROR=y):
>
>   drivers/spi/spi-amd.c:695:9: error: variable 'ret' is uninitialized when used here [-Werror,-Wuninitialized]
>     695 |         return ret;
>         |                ^~~
>   drivers/spi/spi-amd.c:673:9: note: initialize the variable 'ret' to silence this warning
>     673 |         int ret;
>         |                ^
>         |                 = 0
>   1 error generated.
>
> ret is no longer set on anything other than the default switch path.
> Replace ret with a direct return of 0 at the end of the function and
> -EOPNOTSUPP in the default case to resolve the warning.

Correct, thanks.

Reviewed-by: Miquel Raynal <miquel.raynal@xxxxxxxxxxx>