Re: [PATCH 2/2] spi: rockchip-sfc: Add rockchip,fspi compatible

[Krzysztof Kozlowski <krzk@xxxxxxxxxx>]

On 07/01/2025 16:47, Jon Lin wrote:
> 
> diff --git a/drivers/spi/spi-rockchip-sfc.c b/drivers/spi/spi-rockchip-sfc.c
> index 59de351499a0..88fbde27925e 100644
> --- a/drivers/spi/spi-rockchip-sfc.c
> +++ b/drivers/spi/spi-rockchip-sfc.c
> @@ -808,6 +808,7 @@ static const struct dev_pm_ops rockchip_sfc_pm_ops = {
>  };
>  
>  static const struct of_device_id rockchip_sfc_dt_ids[] = {
> +	{ .compatible = "rockchip,fspi"},
>  	{ .compatible = "rockchip,sfc"},
I don't understand why you are adding generic compatible which is not
even used. Use proper SoC specific compatibles and fallbacks when
applicable (see writing bindings document).

Best regards,
Krzysztof