Re: [PATCH 02/24] spi: spi-mem: Add a new controller capability

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Tudor,

>> Among all the spi-memory controllers, I believe all are capable of
>
> nit: SPI memory? or spi memory? but no "-" I think

...

>> changing the spi frequency on the fly. Some of the drivers do not make
>> any frequency setup though. And some others will derive a per-chip
>
> nit: s/per-chip/per chip?

...

>> pre-scaler value which will be used forever.
>
> nit: s/pre-scaler/prescaler?

...

>> + * @per_op_freq: Supports per-operation frequency switching
>
> nit: s/per-operation/per operation?
>
> If you fix the bug that you identified you can add my R-b tag,
> regardless if you address these nits or not:
>
> Reviewed-by: Tudor Ambarus <tudor.ambarus@xxxxxxxxxx>

No idea why I like '-' so much. I removed them all as advised :-)

Thanks!
Miquèl





[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux