Re: [PATCH v5 04/16] spi: dt-bindings: add PWM SPI offload trigger

[Rob Herring <robh@xxxxxxxxxx>]

On Fri, Nov 15, 2024 at 02:18:43PM -0600, David Lechner wrote:
> Add a new binding for using a PWM signal as a trigger for SPI offloads.
> 
> Signed-off-by: David Lechner <dlechner@xxxxxxxxxxxx>
> ---
> 
> v5 changes:
> * Add MAINTAINERS entry
> 
> v4 changes: new patch in v4
> ---
>  .../devicetree/bindings/spi/trigger-pwm.yaml       | 39 ++++++++++++++++++++++
>  MAINTAINERS                                        |  1 +
>  2 files changed, 40 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/spi/trigger-pwm.yaml b/Documentation/devicetree/bindings/spi/trigger-pwm.yaml
> new file mode 100644
> index 000000000000..987638aa4732
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/spi/trigger-pwm.yaml
> @@ -0,0 +1,39 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/spi/trigger-pwm.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Generic SPI offload trigger using PWM

Not really anything specific to SPI offload here.

I think this should be moved to 
bindings/trigger-source/trigger-pwm.yaml.


> +
> +description: Remaps a PWM channel as a trigger source.
> +
> +maintainers:
> +  - David Lechner <dlechner@xxxxxxxxxxxx>
> +
> +$ref: /schemas/spi/trigger-source.yaml#

Including this doesn't really do anything. Will add more detail in its 
patch.

> +
> +properties:
> +  compatible:
> +    const: trigger-pwm
> +
> +  '#trigger-source-cells':
> +    const: 0
> +
> +  pwms:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - '#trigger-source-cells'
> +  - pwms
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    trigger {
> +        compatible = "trigger-pwm";
> +        #trigger-source-cells = <0>;
> +        pwms = <&pwm 0 1000000 0>;
> +    };
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 91a4a7eb6194..a43532a1edde 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -22021,6 +22021,7 @@ F:	include/linux/mtd/spi-nor.h
>  
>  SPI OFFLOAD
>  R:	David Lechner <dlechner@xxxxxxxxxxxx>
> +F:	Documentation/devicetree/bindings/spi/trigger-pwm.yaml
>  F:	Documentation/devicetree/bindings/spi/trigger-source.yaml
>  F:	drivers/spi/spi-offload.c
>  F:	include/linux/spi/spi-offload.h
> 
> -- 
> 2.43.0
>