Aw: Re: [PATCH] dt-bindings: spi: add compatibles for mt7988

[Frank Wunderlich <frank-w@xxxxxxxxxxxxxxx>]

> Gesendet: Montag, 11. November 2024 um 21:38
&gt; Von: "Rob Herring" <robh@xxxxxxxxxx>
&gt; An: "Frank Wunderlich" <linux@xxxxxxxxx>
&gt; CC: "Mark Brown" <broonie@xxxxxxxxxx>, "Krzysztof Kozlowski" <krzk+dt@xxxxxxxxxx>, "Conor Dooley" <conor+dt@xxxxxxxxxx>, "Matthias Brugger" <matthias.bgg@xxxxxxxxx>, "AngeloGioacchino Del Regno" <angelogioacchino.delregno@xxxxxxxxxxxxx>, "Frank Wunderlich" <frank-w@xxxxxxxxxxxxxxx>, "Leilk Liu" <leilk.liu@xxxxxxxxxxxx>, linux-spi@xxxxxxxxxxxxxxx, devicetree@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-mediatek@xxxxxxxxxxxxxxxxxxx
&gt; Betreff: Re: [PATCH] dt-bindings: spi: add compatibles for mt7988
&gt;
&gt; On Sat, Nov 09, 2024 at 11:50:28AM +0100, Frank Wunderlich wrote:
&gt; &gt; From: Frank Wunderlich <frank-w@xxxxxxxxxxxxxxx>
&gt; &gt;
&gt; &gt; MT7988 has 2 different spi controllers. Add their compatibles.
&gt; &gt;
&gt; &gt; Signed-off-by: Frank Wunderlich <frank-w@xxxxxxxxxxxxxxx>
&gt; &gt; ---
&gt; &gt;  Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml | 2 ++
&gt; &gt;  1 file changed, 2 insertions(+)
&gt; &gt;
&gt; &gt; diff --git a/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml b/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml
&gt; &gt; index e1f5bfa4433c..ed17815263a8 100644
&gt; &gt; --- a/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml
&gt; &gt; +++ b/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml
&gt; &gt; @@ -35,6 +35,8 @@ properties:
&gt; &gt;            - enum:
&gt; &gt;                - mediatek,mt7981-spi-ipm
&gt; &gt;                - mediatek,mt7986-spi-ipm
&gt; &gt; +              - mediatek,mt7988-spi-quad
&gt; &gt; +              - mediatek,mt7988-spi-single
&gt; &gt;                - mediatek,mt8188-spi-ipm
&gt; &gt;            - const: mediatek,spi-ipm
&gt;
&gt; Does the fallback make sense for both? Is there some common subset of
&gt; functionality where they are the same?

currently they work only with the fallback compatible, but we see in SDK that there are 2 types...in SDK non-soc specific compatibles are used which was rejected last time.

&gt; Rob
&gt; </frank-w@xxxxxxxxxxxxxxx></frank-w@xxxxxxxxxxxxxxx></leilk.liu@xxxxxxxxxxxx></frank-w@xxxxxxxxxxxxxxx></angelogioacchino.delregno@xxxxxxxxxxxxx></matthias.bgg@xxxxxxxxx></conor+dt@xxxxxxxxxx></krzk+dt@xxxxxxxxxx></broonie@xxxxxxxxxx></linux@xxxxxxxxx></robh@xxxxxxxxxx>