Re: [PATCH v3] dt-bindings: spi: Convert to dtschema

[Krzysztof Kozlowski <krzk@xxxxxxxxxx>]

On Wed, Oct 16, 2024 at 06:54:03PM +0000, Karan Sanghavi wrote:
> Convert bcm2835-aux-spi binding to Dt schema
> 
> Signed-off-by: Karan Sanghavi <karansanghvi98@xxxxxxxxx>

Thank you for your patch. There is something to discuss/improve.


Subject misses device prefix and considering Mark's preference about
spi: it should look like:

spi: dt-bindings: brcm,bcm2835-aux-spi: Convert to dtschema

> ---
> 
> Changes since V2:
>  - Modified the Patch subject
>  - Removed unnecessary description and example
> 

...

> diff --git a/Documentation/devicetree/bindings/spi/brcm,bcm2835-aux-spi.yaml b/Documentation/devicetree/bindings/spi/brcm,bcm2835-aux-spi.yaml
> new file mode 100644
> index 000000000..351019d68
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/spi/brcm,bcm2835-aux-spi.yaml
> @@ -0,0 +1,51 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/spi/brcm,bcm2835-aux-spi.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Broadcom BCM2835 Auxiliary SPI1/2 Controller
> +
> +maintainers:
> +  - Karan Sanghavi <karansanghvi98@xxxxxxxxx>
> +
> +description: The BCM2835 contains two forms of SPI master controller. One is known simply as

This feels loo long. Wrapping is according to coding style (not
checkpatch), so at 80. You can also have line break after "description"
keyword, so:

description:
  The BCM2835 contains ......

Rest looks good, so please send v4 unless Mark could fix these up when
applying.

If sending v4, remember about tag (see explanation below):

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>



<form letter>
This is an automated instruction, just in case, because many review tags
are being ignored. If you know the process, you can skip it (please do
not feel offended by me posting it here - no bad intentions intended).
If you do not know the process, here is a short explanation:

Please add Acked-by/Reviewed-by/Tested-by tags when posting new
versions, under or above your Signed-off-by tag. Tag is "received", when
provided in a message replied to you on the mailing list. Tools like b4
can help here. However, there's no need to repost patches *only* to add
the tags. The upstream maintainer will do that for tags received on the
version they apply.

https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577
</form letter>

Best regards,
Krzysztof