On 26.09.2024 17:19, AlvinZhou wrote: > + > + /* SWAP16 is only applicable when Octal DTR mode */ the comment is redundant, I can already see the condition in the if below. No need to resend, I'll amend when applying. Looking good. > + if (proto == SNOR_PROTO_8_8_8_DTR && nor->flags & SNOR_F_SWAP16) > + op->data.swap16 = true;