Hi Mark, On Wed, Oct 02, 2024 at 01:38:57AM GMT, Mark Brown wrote: > On Tue, 24 Sep 2024 14:40:08 +0100, Ben Dooks wrote: > > In the s3c64xx_flush_fifo() code, the loops counter is post-decremented > > in the do { } while(test && loops--) condition. This means the loops is > > left at the unsigned equivalent of -1 if the loop times out. The test > > after will never pass as if tests for loops == 0. > > > > > > Applied to > > https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next > > Thanks! > > [1/2] spi: s3c64xx: fix timeout counters in flush_fifo > commit: 68a16708d2503b6303d67abd43801e2ca40c208d This still had some pending comments, besides I think it also needed the Fixes tag. Andi