RE: [PATCH v6 08/12] drm/i915/spi: add spi device for discrete graphics

["Usyskin, Alexander" <alexander.usyskin@xxxxxxxxx>]

> Subject: Re: [PATCH v6 08/12] drm/i915/spi: add spi device for discrete
> graphics
> 
> On Mon, 16 Sep 2024, Alexander Usyskin <alexander.usyskin@xxxxxxxxx>
> wrote:
> > diff --git a/drivers/gpu/drm/i915/i915_drv.h
> b/drivers/gpu/drm/i915/i915_drv.h
> > index 39f6614a0a99..b9d4f9be5355 100644
> > --- a/drivers/gpu/drm/i915/i915_drv.h
> > +++ b/drivers/gpu/drm/i915/i915_drv.h
> > @@ -34,6 +34,8 @@
> >
> >  #include <linux/pm_qos.h>
> >
> > +#include <linux/intel_dg_spi_aux.h>
> > +
> >  #include <drm/ttm/ttm_device.h>
> >
> >  #include "display/intel_display_limits.h"
> > @@ -315,6 +317,8 @@ struct drm_i915_private {
> >
> >  	struct i915_perf perf;
> >
> > +	struct intel_dg_spi_dev spi;
> > +
> 
> Sorry, late to the party.
> 
> Can we make that struct intel_dg_spi_dev *spi, drop the include and use
> a forward declaration for the type, and allocate dynamically please?
> 
> Ditto for xe driver.
> 
> struct drm_i915_private is huge, i915_drv.h gets included everywhere,
> and there's no reason everyone should be able to look at the guts of of
> that member.
> 

Thanks for review!
Yes, seem reasonable to move the struct out, I'll look how to do it and
update in the next revision.

Any other comments about Xe/i915 code?
It should be unaffected by changes in spi/mtd part.

- - 
Thanks,
Sasha


> 
> BR,
> Jani.
> 
> 
> --
> Jani Nikula, Intel