Re: [PATCH v8 0/8] Add QPIC SPI NAND driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 9/3/2024 6:38 PM, Miquel Raynal wrote:
Hi,

quic_mdalam@xxxxxxxxxxx wrote on Tue, 3 Sep 2024 14:45:15 +0530:

Hi Miquel,

On 8/20/2024 4:12 PM, Md Sadre Alam wrote:
v8:
   * Fixed compilation warning reported by kernel test robot
   * Added "chip" description in nandc_set_read_loc_first()
   * Added "chip" description" in nandc_set_read_loc_last()
   * Changed data type of read_location0, read_location1,
     read_location2, read_location3, addr0, addr1, cmd, cfg0,
     cfg1, ecc_bch_cfg, ecc_buf_cfg, clrflashstatus, clrreadstatus,
     orig_cmd1, orig_vld to __le32 to fix compilation warning.
   * Included bitfield.h header file in spi-qpic-snand.c to
     fix compilation warning
   * Removed unused variable "steps" variable from
     qcom_spi_ecc_init_ctx_pipelined()
      I have addressed your comments to v6 and further posted till v8.
      Could you please let me know if this is fine.
      and how to get this merged ?

There are still kernel test robot reports, so this means there are
issues in your code that I don't need to point out explicitly, but I am
actively waiting for them to be fixed.

I have fixed most of the sparse warnings after converting __le32 to u32.
However am not able to address the following sparse warnings

	drivers/mtd/nand/raw/qcom_nandc.c:1401:29: sparse: warning: cast to restricted __le32
	drivers/mtd/nand/raw/qcom_nandc.c:1587:30: sparse: warning: cast to restricted __le32
	drivers/mtd/nand/raw/qcom_nandc.c:1588:31: sparse: warning: cast to restricted __le32
	drivers/mtd/nand/raw/qcom_nandc.c:1589:34: sparse: warning: cast to restricted __le32
	drivers/mtd/nand/raw/qcom_nandc.c:2479:47: sparse:    got restricted __le32 [usertype]
	drivers/mtd/nand/raw/qcom_nandc.c:2480:47: sparse:    got restricted __le32 [usertype]
	drivers/mtd/nand/raw/qcom_nandc.c:2616:25: sparse: warning: cast to restricted __le32
	drivers/mtd/nand/raw/qcom_nandc.c:2672:32: sparse: warning: cast to restricted __le32

These warnings are seen with existing kernel code too. For example

	drivers/mtd/ftl.c:299:39: sparse: warning: cast to restricted __le32
	drivers/mtd/ftl.c:387:23: sparse:    got restricted __le32 [usertype]

Hence, can these be ignored as false positives and post the next version of the patches.
Kindly advice.

Thanks
Alam




[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux