Re: [PATCH -next 2/3] spi: geni-qcom: Undo runtime PM changes at driver exit time

[Doug Anderson <dianders@xxxxxxxxxxxx>]

Hi,

On Tue, Sep 3, 2024 at 7:11 PM Jinjie Ruan <ruanjinjie@xxxxxxxxxx> wrote:
>
> It's important to undo pm_runtime_use_autosuspend() with
> pm_runtime_dont_use_autosuspend() at driver exit time unless driver
> initially enabled pm_runtime with devm_pm_runtime_enable()
> (which handles it for you).
>
> Hence, switch to devm_pm_runtime_enable() to fix it.
>
> Fixes: cfdab2cd85ec ("spi: spi-geni-qcom: Set an autosuspend delay of 250 ms")
> Signed-off-by: Jinjie Ruan <ruanjinjie@xxxxxxxxxx>
> ---
>  drivers/spi/spi-geni-qcom.c | 13 +++++--------
>  1 file changed, 5 insertions(+), 8 deletions(-)

Given that this is a "Fix" it should be the first patch in the series.
Your ${SUBJECT} should also not contain "-next". Not only is that not
a convention for the SPI tree (that I'm aware of) it also is probably
wrong since fixes should usually get queued to an earlier tree...

As per my response to patch #1 in your series, the pm_runtime fix also
needs to be first in your series for correctness.


> @@ -1153,10 +1153,9 @@ static int spi_geni_probe(struct platform_device *pdev)
>                 goto spi_geni_release_dma;
>
>         return 0;
> +

Unrelated whitespace change?


-Doug