Re: [PATCH 14/22] dt-bindings: arm-smmu: document the support on SA8255p
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH 14/22] dt-bindings: arm-smmu: document the support on SA8255p
- From: Nikunj Kela <quic_nkela@xxxxxxxxxxx>
- Date: Thu, 29 Aug 2024 08:39:06 -0700
- Cc: <andersson@xxxxxxxxxx>, <konradybcio@xxxxxxxxxx>, <robh@xxxxxxxxxx>, <krzk+dt@xxxxxxxxxx>, <conor+dt@xxxxxxxxxx>, <rafael@xxxxxxxxxx>, <viresh.kumar@xxxxxxxxxx>, <herbert@xxxxxxxxxxxxxxxxxxx>, <davem@xxxxxxxxxxxxx>, <sudeep.holla@xxxxxxx>, <andi.shyti@xxxxxxxxxx>, <tglx@xxxxxxxxxxxxx>, <will@xxxxxxxxxx>, <joro@xxxxxxxxxx>, <jassisinghbrar@xxxxxxxxx>, <lee@xxxxxxxxxx>, <linus.walleij@xxxxxxxxxx>, <amitk@xxxxxxxxxx>, <thara.gopinath@xxxxxxxxx>, <broonie@xxxxxxxxxx>, <wim@xxxxxxxxxxxxxxxxxx>, <linux@xxxxxxxxxxxx>, <robin.murphy@xxxxxxx>, <cristian.marussi@xxxxxxx>, <rui.zhang@xxxxxxxxx>, <lukasz.luba@xxxxxxx>, <vkoul@xxxxxxxxxx>, <quic_gurus@xxxxxxxxxxx>, <agross@xxxxxxxxxx>, <bartosz.golaszewski@xxxxxxxxxx>, <quic_rjendra@xxxxxxxxxxx>, <robimarko@xxxxxxxxx>, <linux-arm-msm@xxxxxxxxxxxxxxx>, <devicetree@xxxxxxxxxxxxxxx>, <linux-kernel@xxxxxxxxxxxxxxx>, <linux-pm@xxxxxxxxxxxxxxx>, <linux-crypto@xxxxxxxxxxxxxxx>, <arm-scmi@xxxxxxxxxxxxxxx>, <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>, <linux-i2c@xxxxxxxxxxxxxxx>, <iommu@xxxxxxxxxxxxxxx>, <linux-gpio@xxxxxxxxxxxxxxx>, <linux-serial@xxxxxxxxxxxxxxx>, <linux-spi@xxxxxxxxxxxxxxx>, <linux-watchdog@xxxxxxxxxxxxxxx>, <kernel@xxxxxxxxxxx>, <quic_psodagud@xxxxxxxxxxx>, <quic_tsoni@xxxxxxxxxxx>, <quic_shazhuss@xxxxxxxxxxx>
- In-reply-to: <ompfueg7civ5spjdumkhd7qgx4cnvjcftznf3z3q5duuxppt5d@fao7zx4oxfm3>
- References: <20240828203721.2751904-1-quic_nkela@quicinc.com> <20240828203721.2751904-15-quic_nkela@quicinc.com> <ompfueg7civ5spjdumkhd7qgx4cnvjcftznf3z3q5duuxppt5d@fao7zx4oxfm3>
- User-agent: Mozilla Thunderbird
On 8/29/2024 12:36 AM, Krzysztof Kozlowski wrote:
> On Wed, Aug 28, 2024 at 01:37:13PM -0700, Nikunj Kela wrote:
>> Add compatible for smmu representing support on SA8255p.
>>
>> Signed-off-by: Nikunj Kela <quic_nkela@xxxxxxxxxxx>
>> ---
>> Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 3 +++
>> 1 file changed, 3 insertions(+)
>>
> Your subjects contain quite redundant/excessive information. In the same
> time they lack information about device.
>
> 1. s/document the support on/add/
> 2. s/SA8255p/SA8255p SMMU-or-whatever-device-it-is/
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>
> Best regards,
> Krzysztof
Okay. I thought arm-smmu tag already indicate which device this patch is
for but would put SMMU explicitly in the subject.
Thanks,
-Nikunj
[Index of Archives]
[Linux Kernel]
[Linux ARM (vger)]
[Linux ARM MSM]
[Linux Omap]
[Linux Arm]
[Linux Tegra]
[Fedora ARM]
[Linux for Samsung SOC]
[eCos]
[Linux Fastboot]
[Gcc Help]
[Git]
[DCCP]
[IETF Announce]
[Security]
[Linux MIPS]
[Yosemite Campsites]
|