Re: [PATCH v2 12/12] arm64: dts: rockchip: Add rk3576-armsom-sige5 board

[Detlev Casanova <detlev.casanova@xxxxxxxxxxxxx>]

Hi Chukun,

On Sunday, 25 August 2024 10:25:09 EDT Chukun Pan wrote:
> Hi,
> 
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dts
> > ...
> > +	leds: leds {
> > +		compatible = "gpio-leds";
> 
> Maybe there should be a blank line.
> 
> > +		work_led: work-led {
> > +			gpios = <&gpio0 RK_PB4 GPIO_ACTIVE_HIGH>;
> > +			linux,default-trigger = "heartbeat";
> > +		};
> > +	};
> 
> Is the color missing?

Actually, after rechecking, this is wrong. There are 2 LEDs on &gpio4:
 - PB2: Green
 - PB1: Red

I can set the green one as heartbeat and the red one as default-on.

> > ...
> > +	vcc_3v3_rtc_s5: regulator-vcc-3v3-rtc-s5 {
> > +		compatible = "regulator-fixed";
> > +		regulator-name = "vcc_3v3_rtc_s5";
> > +		regulator-boot-on;
> > +		regulator-always-on;
> > +		regulator-min-microvolt = <3300000>;
> > +		regulator-max-microvolt = <3300000>;
> > +		vin-supply = <&vcc_5v0_sys>;
> > +	};
> 
> Missing blank line.
> 
> > +	vcc_1v8_s0: regulator-vcc-1v8-s0 {
> > +		compatible = "regulator-fixed";
> > +		regulator-name = "vcc_1v8_s0";
> > +		regulator-boot-on;
> > +		regulator-always-on;
> > +		regulator-min-microvolt = <1800000>;
> > +		regulator-max-microvolt = <1800000>;
> > +		vin-supply = <&vcc_1v8_s3>;
> > +	};
> > ...
> > +&gmac0 {
> > +	phy-mode = "rgmii-rxid";
> 
> Can we use "rgmii-id" and remove tx_delay here?

Indeed, that's better.

> > ...
> > +&sdmmc {
> > +	bus-width = <4>;
> > +	cap-mmc-highspeed;
> > +	cap-sd-highspeed;
> > +	disable-wp;
> > +	max-frequency = <200000000>;
> > +	no-sdio;
> > +	no-mmc;
> > +	non-removable;
> > +	sd-uhs-sdr104;
> > +        vmmc-supply = <&vcc_3v3_s3>;
> 
> Indentation error.
> 
> > +	vqmmc-supply = <&vccio_sd_s0>;
> > +	status = "okay";
> > +};
> > ...
> 
> Thanks,
> Chukun