On 2024/8/19 15:47, Jonas Gorski wrote: > Hi, > > On Mon, 19 Aug 2024 at 05:59, Jinjie Ruan <ruanjinjie@xxxxxxxxxx> wrote: >> >> Add MODULE_DEVICE_TABLE(), so modules could be properly autoloaded >> based on the alias from of_device_id table. > > Your code change adds a MODULE_DEVICE_TABLE() to platform_device_id, > not of_device_id (which is also missing it). Please align change and > message. > > Also since this is a fix, please add an appropriate Fixes tag and Cc stable. > >> >> Signed-off-by: Jinjie Ruan <ruanjinjie@xxxxxxxxxx> > > Apart from that the change looks good. > > Reviewed-by: Jonas Gorski <jonas.gorski@xxxxxxxxx> Jonas, Thank you, I'll fix it, thank you! > > Best Regards, > Jonas