Re: [PATCH 1/4] spi: xcomm: add gpiochip support

[Nuno Sá <noname.nuno@xxxxxxxxx>]

On Thu, 2024-07-04 at 14:53 +0100, Mark Brown wrote:
> On Thu, Jul 04, 2024 at 03:49:12PM +0200, Nuno Sa wrote:
> 
> > +static int spi_xcomm_gpio_get_value(struct gpio_chip *chip, unsigned int
> > offset)
> > +{
> > +	struct spi_xcomm *spi_xcomm = gpiochip_get_data(chip);
> > +
> > +	return spi_xcomm->gpio_val;
> > +}
> 
> It seems like the hardware doesn't support input at all so should there
> even be a get operation?  gpiolib appears to cope fine with omitting it.

Just following recommendations :)

https://elixir.bootlin.com/linux/v6.10-rc6/source/include/linux/gpio/driver.h#L336

- Nuno Sá