Re: [PATCH v5 7/7] dts: ti: k3-am625-beagleplay: Add mikroBUS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 6/27/24 22:12, Nishanth Menon wrote:

On 21:56-20240627, Ayush Singh wrote:
DONOTMERGE
^^ might be better off in the diffstat and explain why DONOT MERGE :)
[...]

There are 2 reasons for DONOTMERGE

1. Mikrobus boards config should not live here. It is supposed to be independent of the system and arch.

2. I am going to be cleaning up and sending this once at least the dt-bindings are approved.


I have included it in the patch to provide some idea about how it will supposedly look like (and anyone who might want to test this stuff). I will try to remember to add it in diffstat in the future.

+	mikrobus_spi_pins_gpio: mikrobus-spi-gpio-pins {
+		pinctrl-single,pins = <
+			AM62X_IOPAD(0x0194, PIN_INPUT, 7) /* (B19) MCASP0_AXR3.GPIO1_7 */
+			AM62X_IOPAD(0x0198, PIN_INPUT, 7) /* (A19) MCASP0_AXR2.GPIO1_8 */
+			AM62X_IOPAD(0x01ac, PIN_INPUT, 7) /* (E19) MCASP0_AFSR.GPIO1_13 */
+			AM62X_IOPAD(0x01b0, PIN_INPUT, 7) /* (A20) MCASP0_ACLKR.GPIO1_14 */
+		>;
+	};
we could potentially get rid of these if we get the gpio-ranges correct
on pinctrl? I have not gotten around to am62x yet - but see this:

https://lore.kernel.org/linux-arm-kernel/20240627162539.691223-1-nm@xxxxxx/T/#t

[...]


Thanks. Will look into this before sending an actual patch for beagleplay dts as well.


Ayush Singh





[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux