Re: [v6 17/20] ARM: dts: aspeed: Add IBM Huygens BMC system

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [v6 17/20] ARM: dts: aspeed: Add IBM Huygens BMC system
From: Markus Elfring <Markus.Elfring@xxxxxx>
Date: Thu, 23 May 2024 21:30:55 +0200
Cc: LKML <linux-kernel@xxxxxxxxxxxxxxx>, Andi Shyti <andi.shyti@xxxxxxxxxx>, Andrew Jeffery <andrew@xxxxxxxxxxxxxxxxxxxx>, Conor Dooley <conor+dt@xxxxxxxxxx>, Joel Stanley <joel@xxxxxxxxx>, Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>, Lakshmi Yadlapati <lakshmiy@xxxxxxxxxx>, Mark Brown <broonie@xxxxxxxxxx>, Ninad Palsule <ninad@xxxxxxxxxxxxx>, Rob Herring <robh@xxxxxxxxxx>
In-reply-to: <910b18b7-3717-4087-b028-fcaf5f2a604b@linux.ibm.com>
References: <20240522192524.3286237-18-eajames@linux.ibm.com> <2fe45df6-01a2-488b-99fb-5ee20491554c@web.de> <910b18b7-3717-4087-b028-fcaf5f2a604b@linux.ibm.com>
Ui-outboundreport: notjunk:1;M01:P0:AvAUgeT2+NE=;92TPdx7IhOKSe1vyjO3YA8PfoWa wzrEU9QnhnZQGo73Zhn8I5Sqdkbp25SsbeS8Z02pMV2BNysdZDsOaNOTnof+7z87NAtoEWv6N 8d8pKYf7xRyloijiXNSDcwt+eknm4+WUFhFp6SRAsaRPnq+p3t0KcTVqrw2wgmGc3jiqe88z3 soX5Ky0VnQ53AU9qJbXHaSu9uuo+8s0GF+emLYmv7caQYZxy/HEna+VYuO9apa1HD/5CzvGsf BxrgcB7H2hqvH5iQ/KTYkycbi4dsJO8T97sd9qXdeA6dcQHKmYjQTCq/ABzI+Q7cXqXib3MSE FUyN/GcKcbhRO6WPeWMef8VUFP/bYkrTCYd8gIWdDjKfaHQVnUK5Q/QIvdHBx2PuOdb3Ol/Fj xb7FvqkLGCXp1MS9UkeBc0pUDXoPnqV0NUQG/D+GkuvAtXytJ+qrg8H+wSt6q3BuYxcg24VZd TvCiA997y0F+NYclHLXF24tQNkGOhC0GbvoRuLAEMuH23arU5zaTZ6FajoQBnLDYTQsYakRhD FIZTvhJSvFfoC8gu/0ygVhZcgmMa3jSwXdc5cExperNWqQhTX7Ut0/pCkVYuWBPAR3bF0kezZ 83GVaUSOcBqbDBorLCwpzSjrRLrQuxjnOc/+dgrBClYK1Qdem8GI2eYq+f/sZ1Mo8wkWjX4b2 fG51IQOVVM8Q4KGxv5lk3V0zKtB2w6Ye/wi6fMKjd0mb7iSjK6gR7TuTqVHqOSTHkl203mOIV lqUHb0wMjGbSbdmhQq/YovQX434I2QJgtbtuDvoTcMKnH0f4DrrZyTWtnWdB9XauuGnydRs6e N0D37WL9Z/2AO/szkiJ5UgnNjIyVVi9tpRdVj3wH+RBUc=
User-agent: Mozilla Thunderbird

>>> The Huygens is a Rainier with modifed FSI wiring.
>> Will imperative wordings become helpful for a better commit message here?
>
>
> This statement is a description of hardware. I cannot word that imperatively.

Please take another look at corresponding improvement possibilities.


> The commit message is imperative - "Add Huygens system".

This information fits to the summary phrase.

Would you like to mention in the changelog that a hardware description
should be extended anyhow?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.9#n94

Regards,
Markus

Follow-Ups:
- Re: [v6 17/20] ARM: dts: aspeed: Add IBM Huygens BMC system
  - From: Conor Dooley

References:
- [PATCH v6 17/20] ARM: dts: aspeed: Add IBM Huygens BMC system
  - From: Eddie James
- Re: [PATCH v6 17/20] ARM: dts: aspeed: Add IBM Huygens BMC system
  - From: Markus Elfring
- Re: [PATCH v6 17/20] ARM: dts: aspeed: Add IBM Huygens BMC system
  - From: Eddie James

Prev by Date: Re: [PATCH v6 17/20] ARM: dts: aspeed: Add IBM Huygens BMC system
Next by Date: Re: [v6 17/20] ARM: dts: aspeed: Add IBM Huygens BMC system
Previous by thread: Re: [PATCH v6 17/20] ARM: dts: aspeed: Add IBM Huygens BMC system
Next by thread: Re: [v6 17/20] ARM: dts: aspeed: Add IBM Huygens BMC system
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel] [Linux ARM (vger)] [Linux ARM MSM] [Linux Omap] [Linux Arm] [Linux Tegra] [Fedora ARM] [Linux for Samsung SOC] [eCos] [Linux Fastboot] [Gcc Help] [Git] [DCCP] [IETF Announce] [Security] [Linux MIPS] [Yosemite Campsites]