On Thu, May 16, 2024 at 12:27 PM Conor Dooley <conor.dooley@xxxxxxxxxxxxx> wrote: > > On Thu, May 16, 2024 at 12:00:29PM +0530, Kanak Shilledar wrote: > > On Tue, May 14, 2024 at 11:44 PM Conor Dooley <conor@xxxxxxxxxx> wrote: > > > > > > On Tue, May 14, 2024 at 12:30:47PM +0530, Kanak Shilledar wrote: > > > > > > > Changes in v3: > > > > - Updated DCO email address > > > > > > I was really hoping you'd tell me why you'd not used the same email > > > address, rather than just sending another version. My ulterior motive is > > > that I wrote the section in email-clients.rst saying that protonmail had > > > WKD issues with kernel.org accounts but apparently proton added a > > > workaround and have yet to be sent an email that confirmed that the > > > workaround fixed things. (I'm not sure that the WKD issues ever applied > > > as there's no GPG key posted for conor+dt@xxxxxxxxxx, only > > > conor@xxxxxxxxxx). > > > > Oh, I am primarily using protonmail and I am aware that there are some > > issues with protonmail and kernel.org so for that reason I am sending my > > patches via @gmail.com address. I was trying out some things with > > gmail and proton so had changed my signing email address to @gmail.com > > apart from sending emails I have no motive on using gmail.com account. > > Also I am adding my protonmail account in the `CC`. > > Hope this helps. > > If this is not the intended route then I will change it and stick > > to one email address. > > I don't care what email you use for stuff, that's your business. I just > want to know if we can remove the section from the docs that says not to > use proton. Maybe you could send me an off-list email to > conor@xxxxxxxxxx from your proton account, so I can see if it ends up > getting encrypted? That'd be helpful if you could. I have sent you a mail off-list using proton. Please let me know if you were able to view it? There is a option to attach public key as well when using protonmail. > > > The patch is fine IMO though, so > > > Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> > > > > Do I need to roll out another version with this reviewed by flag? > > No, Mark should be able to pick that up. There's usually no need to > resend patches solely pick up tags, that's the maintainer's > responsibility. If you're resending for any other reason, then yes, pick > up tags. Alright! > Cheers, > Conor. Thanks and Regards, Kanak Shilledar