On Mon, May 13, 2024 at 12:36:57PM -0400, Ben Wolsieffer wrote: > On Mon, May 13, 2024 at 10:29:49AM +0200, Leonard Göhrs wrote: > > Reverting this commit fixes the issue for me. It may be some time before > > I get around to investigating the issue in detail, so I thought I should > > ask if anyone else has already noticed this as well. > Sorry about that; it looks like the STM32H7/MP platforms require the > controller to be enabled later. I agree that it should be reverted and > I'll try to think of another approach. Can one of you please send a patch with the revert and a changelog explaining the issue? > The STM32H7/MP devices are significantly different from the F4/7 > devices, which makes it difficult to change shared code without causing > problems like this. I wonder if it might be better to split the F4/7 > support into a separate driver. This would duplicate a bit of code, > namely the initialization in probe, the baud rate divider calculation > and the SPI mode config, but would make testing easier and get rid of > the indirection that handles the different register offsets and field > masks on each platform. The code for actually transcieving data and > handling IRQs is already platform specific. That might make sense.
Attachment:
signature.asc
Description: PGP signature
