On Tue, Apr 16, 2024 at 04:40:39PM +0300, Andy Shevchenko wrote: > On Tue, Apr 16, 2024 at 1:09 PM Charles Keepax > <ckeepax@xxxxxxxxxxxxxxxxxxxxx> wrote: > > From: Maciej Strozek <mstrozek@xxxxxxxxxxxxxxxxxxxxx> > > > + ret = devm_add_action(priv->dev, cs42l43_release_sw_node, NULL); > > + if (ret) { > > > + software_node_unregister(&cs42l43_gpiochip_swnode); > > This is not needed when you use devm_add_action_or_reset(); that's why > I mentioned that API and not simple devm_add_action(). Can be fixed > later of course, not a big deal. > Argh... sorry about that, not doing well on this series. Still a few people to look at the series so I will fix it up and doing another spin probably the next couple of days. Thanks, Charles