Re: [PATCH v7 4/4] spi: cs42l43: Add bridged cs35l56 amplifiers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Apr 16, 2024 at 04:40:39PM +0300, Andy Shevchenko wrote:
> On Tue, Apr 16, 2024 at 1:09 PM Charles Keepax
> <ckeepax@xxxxxxxxxxxxxxxxxxxxx> wrote:
> > From: Maciej Strozek <mstrozek@xxxxxxxxxxxxxxxxxxxxx>
> 
> > +               ret = devm_add_action(priv->dev, cs42l43_release_sw_node, NULL);
> > +               if (ret) {
> 
> > +                       software_node_unregister(&cs42l43_gpiochip_swnode);
> 
> This is not needed when you use devm_add_action_or_reset(); that's why
> I mentioned that API and not simple devm_add_action(). Can be fixed
> later of course, not a big deal.
> 

Argh... sorry about that, not doing well on this series. Still a
few people to look at the series so I will fix it up and doing
another spin probably the next couple of days.

Thanks,
Charles




[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux