On Tue, Mar 26, 2024 at 10:12:12PM +0200, Andy Shevchenko wrote: > On Tue, Mar 26, 2024 at 08:02:57PM +0000, Mark Brown wrote: > > It is not clear to me that this makes the kernel side better, it just > > seems to be rewriting the platform data for the sake of it. If it was > > converting to DT there'd be some stuff from it being DT but this keeps > > everything as in kernel as board files, just in a more complex form. > Not really. The benefits with swnode conversion are the following: > - reducing custom APIs / data types between _shared_ (in a sense of > supporting zillion different platforms) driver and a certain board > file > - as an effect of the above, reducing kernel code base, and as the result > make maintenance easier and bug-free for that parts I'm more worried about the possibility of breaking things with swnode support than I am for board files - with board files you've got a good chance of failing to compile if things get messed up, with swnode you can typo a property or whatever and silently fail. > - preparing a driver to be ready for any old board file conversion to DT > as it reduces that churn (you won't need to touch the driver code) The driver appears to already have DT support (there's a compatible for MMP2 in there)?
Attachment:
signature.asc
Description: PGP signature
