Re: [PATCH v1 2/3] spi: xilinx: Add necessary inclusion and forward declaration

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 3/8/24 14:56, Andy Shevchenko wrote:
On Fri, Mar 08, 2024 at 09:21:32AM +0100, Michal Simek wrote:
On 3/7/24 16:43, Andy Shevchenko wrote:
xilinx_spi.h is mnissing inclusion and forward declaration, add them.

...

diff --git a/include/linux/spi/xilinx_spi.h b/include/linux/spi/xilinx_spi.h
   #define __LINUX_SPI_XILINX_SPI_H
+#include <linux/types.h>
+
+struct spi_board_info;
+
   /**
    * struct xspi_platform_data - Platform data of the Xilinx SPI driver
    * @num_chipselect:	Number of chip select by the IP.

Likely correct but forget how to check it with tools.

I'm not sure which tools we have to check this.

The types.h is needed for uXX
The forward declaration for the pointer to the mentioned type.

All this has been derived from reading the file.

No issue with it. But I am quite sure there was a tool which was able to find it out and report it. But forgot which one was it.

M




[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux