Re: [PATCH v1 1/2] spi: pxa2xx: Kill pxa2xx_set_spi_info()

[Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>]

On Thu, Mar 07, 2024 at 05:30:10PM +0100, Arnd Bergmann wrote:
> On Thu, Mar 7, 2024, at 17:07, Andy Shevchenko wrote:
> > There is the only one user of the pxa2xx_set_spi_info(). Unexport it
> > and inline to the actual user.
> >
> I have no idea why you care about this,

PXA2xx headers contain a lot of legacy information for pre-OF era.
Besides slowing down the builds, this also pollutes an exported
namespace on many platforms where it's even not being used!

But this is just an ad-hoc clean up, as the main target to me was CS clean up
(as per next patch).

> but it's a nice cleanup,
> so I'm happy to see this get merged through the spi tree if
> that helps. Let me know if I should take it through the soc
> tree instead.

Thank you for the review!

...

> > -/* pxa2xx-spi platform-device ID equals respective SSP platform-device ID + 1 */
> 
> This comment might still be useful.

Okay.

...

> >  	spi_register_board_info(ARRAY_AND_SIZE(spitz_spi_devices));
> 
> I think the normal interface these days would be
> platform_device_register_data(), which does it all in one step.

I'm not sure how is this related to the SPI board info registration.

-- 
With Best Regards,
Andy Shevchenko