There are the following issues with the current code: - inconsistent use of 0xFF and -1 for invalid chip select pin - inconsistent plain or BIT() use with a hard-to-understand comment - wrong types used for last_cs_* fields Fix all of these here. Andy Shevchenko (3): spi: Consistently use BIT for cs_index_mask spi: Fix types of the last chip select storage variables spi: Introduce SPI_INVALID_CS and is_valid_cs() drivers/spi/spi.c | 74 +++++++++++++++++++---------------------- include/linux/spi/spi.h | 12 +++---- 2 files changed, 40 insertions(+), 46 deletions(-) -- 2.43.0.rc1.1.gbec44491f096