Hello Mark, On Sat, Feb 10, 2024 at 05:40:07PM +0100, Uwe Kleine-König wrote: > I failed to adapt this driver because it's not enabled in a powerpc > allmodconfig build and also wasn't hit by my grep expertise. Fix > accordingly. > > Reported-by: kernel test robot <lkp@xxxxxxxxx> > Closes: https://lore.kernel.org/oe-kbuild-all/202402100815.XQXw9XCF-lkp@xxxxxxxxx/ > Fixes: 2259233110d9 ("spi: bitbang: Follow renaming of SPI "master" to "controller"") > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> This patch made it into v6.8-rc5 as commit de4af897ddf242aea18ee90d3ad2e21b4e64359c. However 2259233110d9 (i.e. the commit that renamed "master" to "ctlr" and missed to adapt spi-ppc4xx.c) isn't in v6.8-rc5 but still waits in next for the merge window. This patch applied to v6.8-rc5 made the driver fail to build. Assuming we don't want to have this problem in v6.8, I suggest to revert de4af897ddf2 and reapply it on top of your next branch. If you're interested to prevent such problems in the future, there is a tool in https://github.com/krzk/tools that can catch this type of problem: linux$ ~/gsrc/tools/linux/verify_fixes.sh . v6.8-rc1..de4af897ddf2 Commit: de4af897ddf2 ("spi: ppc4xx: Fix fallout from rename in struct spi_bitbang") Fixes tag: Fixes: 2259233110d9 ("spi: bitbang: Follow renaming of SPI "master" to "controller"") Has these problem(s): - Target SHA should be an ancestor of your tree Thanks to Anthony for reporting this problem (by private mail, so I only added him to Bcc). Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |
Attachment:
signature.asc
Description: PGP signature
