Hi, This fixes runtime PM and system-wide suspend for the cadence-qspi driver. Seeing how runtime PM and autosuspend are enabled by default, I believe this affects all users of the driver. This series has been tested on both Mobileye EyeQ5 hardware and the TI J7200 EVM board, under s2idle. Thanks all, Théo Signed-off-by: Théo Lebrun <theo.lebrun@xxxxxxxxxxx> --- Changes in v4: - Take Reviewed-by Dhruva Gole on patch 1/4. - Fix struct dev_pm_ops declaration to avoid -Wunused-function warning when CONFIG_PM_SLEEP=n. Replace SET_*_PM_OPS() by *_PM_OPS(). See kernel test robot warning: https://lore.kernel.org/oe-kbuild-all/202402221505.712Q7MSU-lkp@xxxxxxxxx/ - Link to v3: https://lore.kernel.org/r/20240209-cdns-qspi-pm-fix-v3-0-540ac222f26b@xxxxxxxxxxx Changes in v3: - Move both bugfix patches to the start of the series. - Remove Fixes: trailer from the function renaming patch. - Link to v2: https://lore.kernel.org/r/20240205-cdns-qspi-pm-fix-v2-0-2e7bbad49a46@xxxxxxxxxxx Changes in v2: - Split the initial change into three separate commits, to make intents clearer. - Mark controller as suspended during the system-wide suspend. - Link to v1: https://lore.kernel.org/r/20240202-cdns-qspi-pm-fix-v1-1-3c8feb2bfdd8@xxxxxxxxxxx --- Théo Lebrun (4): spi: cadence-qspi: fix pointer reference in runtime PM hooks spi: cadence-qspi: remove system-wide suspend helper calls from runtime PM hooks spi: cadence-qspi: put runtime in runtime PM hooks names spi: cadence-qspi: add system-wide suspend and resume callbacks drivers/spi/spi-cadence-quadspi.c | 33 +++++++++++++++++++++------------ 1 file changed, 21 insertions(+), 12 deletions(-) --- base-commit: 13acce918af915278e49980a3038df31845dbf39 change-id: 20240202-cdns-qspi-pm-fix-29600cc6d7bf Best regards, -- Théo Lebrun <theo.lebrun@xxxxxxxxxxx>