Hello, On Wed Feb 7, 2024 at 9:33 AM CET, Dhruva Gole wrote: > On Feb 05, 2024 at 15:57:29 +0100, Théo Lebrun wrote: > > Follow kernel naming convention with regards to power-management > > callback function names. > > > > The convention in the kernel is: > > - prefix_suspend means the system-wide suspend callback; > > - prefix_runtime_suspend means the runtime PM suspend callback. > > The same applies to resume callbacks. > > > > Fixes: 0578a6dbfe75 ("spi: spi-cadence-quadspi: add runtime pm support") > > Not sure if it's a bug as such since there's no functional change other > than renaming. I see where you come from. I'll fix it when/if there is a second revision. [...] > No objections as such, > Reviewed-by: Dhruva Gole <d-gole@xxxxxx> Thanks! -- Théo Lebrun, Bootlin Embedded Linux and Kernel engineering https://bootlin.com