Hi Mark, On Feb 05, 2024 at 15:12:10 +0000, Mark Brown wrote: > On Mon, Feb 05, 2024 at 03:57:30PM +0100, Théo Lebrun wrote: > > dev_get_drvdata() gets used to acquire the pointer to cqspi and the SPI > > controller. Neither embed the other; this lead to memory corruption. > > > > On a given platform (Mobileye EyeQ5) the memory corruption is hidden > > inside cqspi->f_pdata. Also, this uninitialised memory is used as a > > mutex (ctlr->bus_lock_mutex) by spi_controller_suspend(). > > Please place fixes at the start of serieses so that they don't end up > with spurious dependencies on other changes and can more easily be > applied as fixes. Didn't really understand the comment here, aren't the 1,2 and 3 patches fixes and the last one the non-fix? Thus fixes are indeed placed at start of this series right? Can you help understand with some example series? -- Best regards, Dhruva Gole <d-gole@xxxxxx>