On Tue, Feb 06, 2024 at 02:01:27PM +0100, frut3k7 wrote:
> On Tue, Feb 6, 2024 at 10:37 AM Mark Brown <broonie@xxxxxxxxxx> wrote:
> > On Mon, Feb 05, 2024 at 08:18:05PM +0100, Paweł Owoc wrote:
> > > + { .compatible = "qca,spidev", .data = &spidev_of_check },
> > No, this needs to correspond to the hardware being controlled via spidev
> > not to an implementation detail. Any new compatibles also need to be
> > documented.
> The device for which I want to add compatibility is originally used in the
> router and this is what the dts fragment looks like:
>
> spi@3 {
> compatible = "qca,spidev";
> reg = <0x00>;
> spi-max-frequency = <0x16e3600>;
> };
> };
> According to this commit, Qualcomm use this compatibility:
> https://github.com/dissent1/msm-2/commit/d6160218393552fea1b7973787f2bd154f870ee2
This is out of tree, it's not exactly a good guide for mainline. The DT
should describe the hardware, not how some particular software stack
chooses to drive it.
> > I'm also missing patch 2 of this series so don't know what's going on
> > there.
> The second patch was sent only to the devicetree bindings project:
> https://lore.kernel.org/all/20240205191828.998783-1-frut3k7@xxxxxxxxx/
> It's probably done wrong...
You should send the bindings change along with the driver change, they
usually get merged together.
Attachment:
signature.asc
Description: PGP signature
