Re: [PATCH v1 1/1] spi: fsl-dspi: Unify error messaging in dspi_request_dma()

[Andy Shevchenko <andy.shevchenko@xxxxxxxxx>]

On Sun, Feb 4, 2024 at 8:31 PM Vladimir Oltean <olteanv@xxxxxxxxx> wrote:
> On Sun, Feb 04, 2024 at 08:24:17PM +0200, Vladimir Oltean wrote:

...

> > Passing -EINVAL to dev_err_probe() here doesn't work. It overwrites the "ret"
> > from dmaengine_slave_config().

> Ah, the original code also ignores the dmaengine_slave_config() return
> code and replaces it with -EINVAL? I wonder why that is... It doesn't
> appear to be a widespread pattern. Pretty arbitrary. Could you please
> make 2 patches, one which preserves the original return code and another
> which uses dev_err_probe()?

Sure.

-- 
With Best Regards,
Andy Shevchenko