Re: [PATCH v2] spi: imx: fix the burst length at DMA mode and CPU mode

[Carlos Song <carlos.song@xxxxxxx>]

> -----Original Message-----
> From: Francesco Dolcini <francesco@xxxxxxxxxx>
> Sent: Thursday, February 1, 2024 4:52 PM
> To: Carlos Song <carlos.song@xxxxxxx>
> Cc: Francesco Dolcini <francesco@xxxxxxxxxx>; broonie@xxxxxxxxxx;
> shawnguo@xxxxxxxxxx; s.hauer@xxxxxxxxxxxxxx; kernel@xxxxxxxxxxxxxx;
> dl-linux-imx <linux-imx@xxxxxxx>; benjamin@xxxxxxxxxx;
> stefanmoring@xxxxxxxxx; linux-spi@xxxxxxxxxxxxxxx;
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: [EXT] Re: [PATCH v2] spi: imx: fix the burst length at DMA mode and CPU
> mode
> 
> Caution: This is an external email. Please take care when clicking links or opening
> attachments. When in doubt, report the message using the 'Report this email'
> button
> 
> 
> On Thu, Feb 01, 2024 at 02:02:36AM +0000, Carlos Song wrote:
> > > From: Francesco Dolcini <francesco@xxxxxxxxxx> Add #include
> > > <linux/bits.h> given you are using BITS_PER_BYTE
> > >
> > I found that <linux/property.h> has been included in spi-imx.c driver.
> > And <linux/bits.h> has been included in <linux/property.h>.
> > So I didn't add the "#include <linux/bits.h>" on purpose.
> 
> I think you should be explicit and include this header.
> Code get refactored all the time and you can prevent issues this way.
> 
Hi，
Thank you! This is acceptable, I will include <linux/bits.h> explicitly and send V3.

BR
Carlos

> Francesco
>