Re: [PATCH 6/7] arm64: dts: exynos: Add PDMA node for Exynos850

[Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>]

On 20/01/2024 02:29, Sam Protsenko wrote:
> Enable PDMA node. It's needed for multiple peripheral modules, like SPI.
> Use "arm,pl330-broken-no-flushp" quirk, as otherwise SPI transfers in
> DMA mode often fail with error like this:
> 
>     I/O Error: rx-1 tx-1 rx-f tx-f len-786 dma-1 res-(-5)
> 
> Signed-off-by: Sam Protsenko <semen.protsenko@xxxxxxxxxx>
> ---
>  arch/arm64/boot/dts/exynos/exynos850.dtsi | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/exynos/exynos850.dtsi b/arch/arm64/boot/dts/exynos/exynos850.dtsi
> index da3f4a791e68..cd0a452cd6b4 100644
> --- a/arch/arm64/boot/dts/exynos/exynos850.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynos850.dtsi
> @@ -197,6 +197,16 @@ gic: interrupt-controller@12a01000 {
>  						 IRQ_TYPE_LEVEL_HIGH)>;
>  		};
>  
> +		pdma0: dma-controller@120c0000 {

Looks misordered. Keep unit-address order.

> +			compatible = "arm,pl330", "arm,primecell";
> +			reg = <0x120c0000 0x1000>;
> +			interrupts = <GIC_SPI 479 IRQ_TYPE_LEVEL_HIGH>;
> +			clocks = <&cmu_core CLK_GOUT_PDMA_CORE_ACLK>;
> +			clock-names = "apb_pclk";

Best regards,
Krzysztof