Re: [PATCH] spi: Drop warning from spi_stop_queue()

[Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>]

Hi Uwe,

On Sat, Sep 16, 2023 at 6:14 PM Uwe Kleine-König
<u.kleine-koenig@xxxxxxxxxxxxxx> wrote:
> Both callers of spi_stop_queue() (i.e. spi_destroy_queue() and
> spi_controller_suspend()) already emit an error message if
> spi_stop_queue() fails. Another warning in this case isn't helpful, so
> drop it.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>

Thanks for your patch, which is now commit 9386c958beb77aee ("spi:
Drop warning from spi_stop_queue()") in spi/for-next.

> --- a/drivers/spi/spi.c
> +++ b/drivers/spi/spi.c
> @@ -2093,10 +2093,6 @@ static int spi_stop_queue(struct spi_controller *ctlr)
>
>         spin_unlock_irqrestore(&ctlr->queue_lock, flags);
>
> -       if (ret) {
> -               dev_warn(&ctlr->dev, "could not stop message queue\n");
> -               return ret;
> -       }
>         return ret;
>  }

Why did you decide to remove the printed warning from the callee,
instead of the multiple printed warnings from the callers?
The alternative would have reduced kernel size a bit more.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds