RE: [PATCH v9 4/4] gpio: update Intel LJCA USB GPIO driver

["Wu, Wentong" <wentong.wu@xxxxxxxxx>]

> From: sakari.ailus@xxxxxxxxxxxxxxx <sakari.ailus@xxxxxxxxxxxxxxx>
> 
> Hi Wentong, Linus,
> 
> On Thu, Aug 17, 2023 at 07:07:54AM +0000, Wu, Wentong wrote:
> > > From: Linus Walleij <linus.walleij@xxxxxxxxxx>
> > >
> > > On Thu, Aug 17, 2023 at 12:32 AM Wentong Wu <wentong.wu@xxxxxxxxx>
> > > wrote:
> > >
> > > > This driver communicate with LJCA GPIO module with specific
> > > > protocol through interfaces exported by LJCA USB driver.
> > > > Update the driver according to LJCA USB driver's changes.
> > > >
> > > > Signed-off-by: Wentong Wu <wentong.wu@xxxxxxxxx>
> > > > Reviewed-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
> > >
> > > This patch does several things at the same time, consider the "one
> > > technical step per patch" approach, for some definition of a
> > > "technical step". The upside is that git bisect gets better precision when
> something goes sidewise.
> >
> > Ack, thanks. I will follow this going forward.
> 
> The old LJCA GPIO driver got added without the rest of the LJCA, including the
> main driver (now 1st patch of this set). I might have just reverted the patch that
> added the old one and put the new one on top.
> 
> The old driver was never usable AFAIU and there are many changes as Linus
> noted. It would be easier to review as new driver.
> 
> I wonder what others think.

Agree, Thanks

BR,
Wentong
> 
> --
> Regards,
> 
> Sakari Ailus