> @@ -909,10 +901,6 @@ static int a3700_spi_probe(struct platform_device *pdev)
>
> static void a3700_spi_remove(struct platform_device *pdev)
> {
> - struct spi_controller *host = platform_get_drvdata(pdev);
> - struct a3700_spi *spi = spi_controller_get_devdata(host);
> -
> - clk_unprepare(spi->clk);
Hi.
No point in keeping an empty remove function. Drop the whole thing now
there is nothing to do.
Jonathan
> }
>
> static struct platform_driver a3700_spi_driver = {
Re: [PATCH -next 02/25] spi: armada-3700: Use helper function devm_clk_get_prepared()
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH -next 02/25] spi: armada-3700: Use helper function devm_clk_get_prepared()
- From: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
- Date: Tue, 22 Aug 2023 16:55:24 +0100
- Cc: <broonie@xxxxxxxxxx>, <chin-ting_kuo@xxxxxxxxxxxxxx>, <clg@xxxxxxxx>, <joel@xxxxxxxxx>, <andrew@xxxxxxxx>, <florian.fainelli@xxxxxxxxxxxx>, <rjui@xxxxxxxxxxxx>, <sbranden@xxxxxxxxxxxx>, <bcm-kernel-feedback-list@xxxxxxxxxxxx>, <fancer.lancer@xxxxxxxxx>, <olteanv@xxxxxxxxx>, <neil.armstrong@xxxxxxxxxx>, <khilman@xxxxxxxxxxxx>, <jbrunet@xxxxxxxxxxxx>, <martin.blumenstingl@xxxxxxxxxxxxxx>, <conor.dooley@xxxxxxxxxxxxx>, <daire.mcnamara@xxxxxxxxxxxxx>, <matthias.bgg@xxxxxxxxx>, <angelogioacchino.delregno@xxxxxxxxxxxxx>, <avifishman70@xxxxxxxxx>, <tmaimon77@xxxxxxxxx>, <tali.perry1@xxxxxxxxx>, <venture@xxxxxxxxxx>, <yuenn@xxxxxxxxxx>, <benjaminfair@xxxxxxxxxx>, <linus.walleij@xxxxxxxxxx>, <heiko@xxxxxxxxx>, <linux-spi@xxxxxxxxxxxxxxx>, <linux-aspeed@xxxxxxxxxxxxxxxx>, <openbmc@xxxxxxxxxxxxxxxx>, <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>, <linux-rpi-kernel@xxxxxxxxxxxxxxxxxxx>, <linux-amlogic@xxxxxxxxxxxxxxxxxxx>, <linux-riscv@xxxxxxxxxxxxxxxxxxx>, <linux-mediatek@xxxxxxxxxxxxxxxxxxx>, <linux-rockchip@xxxxxxxxxxxxxxxxxxx>
- In-reply-to: <20230822131237.1022815-3-lizetao1@huawei.com>
- Organization: Huawei Technologies Research and Development (UK) Ltd.
- References: <20230822131237.1022815-1-lizetao1@huawei.com> <20230822131237.1022815-3-lizetao1@huawei.com>
- References:
- Prev by Date: Re: [PATCH -next] spi: at91-usart: Use PTR_ERR_OR_ZERO() to simplify code
- Next by Date: Re: [PATCH -next 24/25] spi: spl022: Use helper function devm_clk_get_enabled()
- Previous by thread: [PATCH -next 02/25] spi: armada-3700: Use helper function devm_clk_get_prepared()
- Next by thread: [PATCH -next 04/25] spi: ath79: Use helper function devm_clk_get_enabled()
- Index(es):
 |