Re: [PATCH -next v2 19/23] spi: sh-msiof: switch to use modern name

[Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>]

Hi Yang,

On Thu, Aug 17, 2023 at 7:07 AM Yang Yingliang <yangyingliang@xxxxxxxxxx> wrote:
> Change legacy name master/slave to modern name host/target.
>
> No functional changed.
>
> Signed-off-by: Yang Yingliang <yangyingliang@xxxxxxxxxx>

Thanks for your patch!

> --- a/drivers/spi/spi-sh-msiof.c
> +++ b/drivers/spi/spi-sh-msiof.c

> @@ -1175,7 +1175,7 @@ static int sh_msiof_request_dma(struct sh_msiof_spi_priv *p)
>         struct device *tx_dev, *rx_dev;
>
>         if (dev->of_node) {
> -               /* In the OF case we will get the slave IDs from the DT */
> +               /* In the OF case we will get the target IDs from the DT */

This comment refers to DMA slave IDs, so it should not be changed (yet).

>                 dma_tx_id = 0;
>                 dma_rx_id = 0;
>         } else if (info && info->dma_tx_id && info->dma_rx_id) {

The rest LGTM.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds