Re: [PATCH v13 0/2] spi: loongson: add bus driver for the loongson spi

[Mark Brown <broonie@xxxxxxxxxx>]

On Tue, 13 Jun 2023 15:58:32 +0800, Yinbo Zhu wrote:
> Loongson platform support spi hardware controller and this series patch
> was to add spi driver and binding support.
> 
> Change in v2:
> 		1. This [PATCH v2 1/2] dt-bindings patch need depend on clk patch:
> 	 	   https://
> 		   lore.kernel.org/all/20230307115022.12846-1-zhuyinbo@xxxxxxxxxxx/
> 		2. Remove the clock-names in spi yaml file.
> 		3. Add "loongson,ls7a-spi" compatible in spi yaml file.
> 		4. Add an || COMPILE_TEST and drop && PCI then add some CONFIG_PCI
> 		   macro to limit some pci code.
> 		5. Make the spi driver top code comment block that use C++ style.
> 		6. Drop spi->max_speed_hz.
> 		7. Add a spin_lock for loongson_spi_setup.
> 		8. Add a timeout and cpu_relax() in loongson_spi_write_read_8bit.
> 		9. Add spi_transfer_one and drop transfer and rework entire spi
> 		   driver that include some necessary changes.
> 		10. Use module_init replace subsys_initcall.
> 		11. About PM interface that I don't find any issue so I don't add
> 		    any changes.
> Change in v3:
> 		1. This [PATCH v3 1/2] dt-bindings patch need depend on clk patch:
> 		   https://
> 		   lore.kernel.org/all/20230323025229.2971-1-zhuyinbo@xxxxxxxxxxx/
> 		2. Drop the unused blank line in loongson,ls-spi.yaml file.
> 		3. Replace clock minItems with clock maxItems in yaml file.
> 		4. Separate spi driver into platform module, pci module and core
> 		   module.
> 		5. Replace DIV_ROUND_UP with DIV_ROUND_UP_ULL to fix compile error
> 		   "undefined reference to `__aeabi_uldivmod'" and  "__udivdi3 undefined"
> 		   that reported by test robot.
> 		6. Remove the spin lock.
> 		7. Clear the loongson_spi->hz and loongson_spi->mode in setup to fixup
> 		   the issue that multiple spi device transfer that maybe cause spi was
> 		   be misconfigured.
> Change in v4:
> 		1. This [PATCH v4 1/2] dt-bindings patch need depend on clk patch:
> 		   https://
> 		   lore.kernel.org/all/20230323025229.2971-1-zhuyinbo@xxxxxxxxxxx/
> 		2. Add "#include <linux/io.h>" in spi-loongson-core.c for fix the compile
> 		   issue which devm_ioremap no declaration.
> 		3. Add "EXPORT_SYMBOL_GPL(loongson_spi_dev_pm_ops)" in
> 		   spi-loongson-core.c for fix the compile issue which
> 		   loongson_spi_dev_pm_ops undefined.
> Change in v5:
> 		1. Get rid of the clock patch's dependency and open-code the clock IDs.
> 		2. Fixup checkpatch issue that by installed ply and gitpython package
> 		   locally, but this series of patch's code doesn't have any change.
> Change in v6:
> 		1. Remove the "#include <dt-bindings/clock/loongson,ls2k-clk.h>" in
> 		   yaml file.
> Change in v7:
> 		1. Remove the "loongson,ls7a-spi" and change yaml file name as
> 		   "loongson,ls2k-spi.yaml".
> 		2. Use module_pci_driver and module_platform_driver to replace
> 		   module_init and module_exit.
> 		3. Drop ".owner	= THIS_MODULE" in spi platform driver.
> 		4. Add devm_spi_alloc_master devm_spi_register_master to simplify code.
> 		5. Add pci_disable_device() in loongson_spi_pci_unregister.
> Change in v8:
> 		1. Add reviewed-by information for spi bindings patch.
> 		2. Fixup the uncorrect spi yaml file path in MAINTAINERS file.
> 		3. Add spi_master_suspend and spi_master_resume in spi pm function.
> Change in v9:
> 		1. Make spi_master_suspend go first in pm suspend.
> Change in v10:
> 		1. Fix the compile issue about of_node_get and of_get_property no
> 		   declaration.
> 		2. set config SPI_LOONGSON_CORE invisible.
> 		3. Captial "spi" in commit log and Kconfig file.
> 		4. Write header files in alphabetical order.
> 		5. Use clamp_val, GENMASK() and BIT() in spi clock setting.
> 		6. Optimize clock and mode setting code.
> 		7. Use readb_poll_timeout in loongson_spi_write_read_8bit.
> 		8. Remove some useless dmesg print.
> 		9. Use device_set_node replace of_node_get.
> 		10. Use dev_err_probe in code.
> 		11. Use devm_clk_get_optional replace devm_clk_get.
> 		12. Remove SPI_NO_CS for drop 2k500 non common type spi.
> 		13. Use pcim_enable_device() and pcim_iomap_regions() in spi pci
> 		    driver.
> 		14. Passing the remapped address in loongson_spi_init_master.
> 		15. Remove the useless goto flag "err_out".
> 		16. Use pci vendor id in pci_ids.h.
> 		17. Use devm_platform_ioremap_resource in spi platform driver.
> 		18. Remove the useless item in pci_device_id.
> 		19. Remove the inned comma in of_device_id.
> 		20. Add some headfile in spi_loongson.h.
> 		21. Remove the useless extern for loongson_spi_init_master in
> 		    spi_loongson.h.
> Change in v11:
> 		1. Use spi_get_chipselect() to replace all spi->chip_select in
> 		   spi driver
> Change in v12:
> 		1. Reword the dt-bindings patch title.
> 		2. Use a specific spi compatible in dt-bindings and spi driver.
> 		3. Add Cc list for the reviewers of the previous version.
> 		4. Add a static for rdiv[12] array in loongson_spi_set_clk.
> 		5. Fixup the compile warning for spi HZ that reported by robot.
> 		6. Use "#define LOONGSON_... BIT(0)" in readb_poll_timeout.
> 		7. Add a error code return that when write spi failed.
> 		8. Use spi_controller* instead of spi_master* in all cases.
> 		9. Check for the error first which for clock gain.
> 		10. Drop the ->remove() in spi pci driver.
> 		11. Drop the comma for the terminator entry in pci_device_id.
> 		12. Adjust the head file in spi driver.
> 		13. Use forward declarations for device and spi_controller.
> Change in v13:
> 		1. Reword the dt-bindings patch title.
> 		2. Add the items for compatible with 2k500 in dts-bindings.
> 		3. Add a bit changes in commit log.
> 		4. Add a Reviewed-by for spi driver patch.
> 		5. Rework the function loongson_spi_set_cs.
> 		6. Use GENMASK() to replace some constant in function
> 		   loongson_spi_set_clk.
> 		7. Add or remove some blank lines.
> 		8. Use LOONGSON_SPI_PARA_MEM_EN replace a constant in
> 		   loongson_spi_prepare_message.
> 		9. Use SPI_MODE_X_MASK to replace "SPI_CPOL | SPI_CPHA".
> 		10. Use USEC_PER_MSEC to replace MSEC_PER_SEC.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/2] spi: dt-bindings: add loongson spi
      commit: b350e6c6297aaa2533da23a21398751eeeecc101
[2/2] spi: loongson: add bus driver for the loongson spi controller
      commit: 6c7a864007b66e60a3f64858a9555efed408b048

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark