On Fri, Jul 28, 2023 at 03:57:29PM +0800, Chen Jiahao wrote: > Refering to platform_get_irq()'s definition, the return value has > already been checked if ret < 0, and printed via dev_err_probe(). > Calling dev_err_probe() one more time outside platform_get_irq() > is obviously redundant. > > Furthermore, platform_get_irq() will never return irq equals 0, > removing spi->irq == 0 checking to clean it up. > > Signed-off-by: Chen Jiahao <chenjiahao16@xxxxxxxxxx> > --- > drivers/spi/spi-microchip-core.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/spi/spi-microchip-core.c b/drivers/spi/spi-microchip-core.c > index b59e8a0c5b97..b451cd4860ec 100644 > --- a/drivers/spi/spi-microchip-core.c > +++ b/drivers/spi/spi-microchip-core.c > @@ -530,10 +530,8 @@ static int mchp_corespi_probe(struct platform_device *pdev) > return PTR_ERR(spi->regs); > > spi->irq = platform_get_irq(pdev, 0); > - if (spi->irq <= 0) > - return dev_err_probe(&pdev->dev, -ENXIO, > - "invalid IRQ %d for SPI controller\n", > - spi->irq); > + if (spi->irq < 0) > + return spi->irq; Thanks for the update, looks fine to me. Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> Thanks, Conor. > > ret = devm_request_irq(&pdev->dev, spi->irq, mchp_corespi_interrupt, > IRQF_SHARED, dev_name(&pdev->dev), master); > -- > 2.34.1 >
Attachment:
signature.asc
Description: PGP signature
