Re: [PATCH v2 09/15] spi: Use struct_size() helper

Date Prev

Date Next

Thread Prev

Thread Next

Date Index

Thread Index

Subject: Re: [PATCH v2 09/15] spi: Use struct_size() helper

From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

Date: Mon, 10 Jul 2023 19:12:22 +0300

Cc: Mark Brown <broonie@xxxxxxxxxx>, Cristian Ciocaltea <cristian.ciocaltea@xxxxxxxxxxxxx>, Yang Yingliang <yangyingliang@xxxxxxxxxx>, Amit Kumar Mahapatra via Alsa-devel <alsa-devel@xxxxxxxxxxxxxxxx>, Neil Armstrong <neil.armstrong@xxxxxxxxxx>, Tharun Kumar P <tharunkumar.pasumarthi@xxxxxxxxxxxxx>, Vijaya Krishna Nivarthi <quic_vnivarth@xxxxxxxxxxx>, Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>, linux-spi@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-amlogic@xxxxxxxxxxxxxxxxxxx, linux-mediatek@xxxxxxxxxxxxxxxxxxx, linux-arm-msm@xxxxxxxxxxxxxxx, linux-rockchip@xxxxxxxxxxxxxxxxxxx, linux-riscv@xxxxxxxxxxxxxxxxxxx, linux-stm32@xxxxxxxxxxxxxxxxxxxxxxxxxxxx, linux-trace-kernel@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, Richard Cochran <richardcochran@xxxxxxxxx>, Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx>, Heiko Stuebner <heiko@xxxxxxxxx>, Alexandre Torgue <alexandre.torgue@xxxxxxxxxxx>, Max Filippov <jcmvbkbc@xxxxxxxxx>, Fabio Estevam <festevam@xxxxxxxxx>, Jerome Brunet <jbrunet@xxxxxxxxxxxx>, Kevin Hilman <khilman@xxxxxxxxxxxx>, Tudor Ambarus <tudor.ambarus@xxxxxxxxxx>, Andy Gross <agross@xxxxxxxxxx>, NXP Linux Team <linux-imx@xxxxxxx>, Alain Volmat <alain.volmat@xxxxxxxxxxx>, Orson Zhai <orsonzhai@xxxxxxxxx>, Radu Pirea <radu_nicolae.pirea@xxxxxx>, Maxime Coquelin <mcoquelin.stm32@xxxxxxxxx>, Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>, Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>, Steven Rostedt <rostedt@xxxxxxxxxxx>, Sanjay R Mehta <sanju.mehta@xxxxxxx>, Baolin Wang <baolin.wang@xxxxxxxxxxxxxxxxx>, Paul Walmsley <paul.walmsley@xxxxxxxxxx>, Matthias Brugger <matthias.bgg@xxxxxxxxx>, AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>, Bjorn Andersson <andersson@xxxxxxxxxx>, Nicolas Ferre <nicolas.ferre@xxxxxxxxxxxxx>, Serge Semin <fancer.lancer@xxxxxxxxx>, Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>, Palmer Dabbelt <palmer@xxxxxxxxxxx>, Masami Hiramatsu <mhiramat@xxxxxxxxxx>, Pengutronix Kernel Team <kernel@xxxxxxxxxxxxxx>, Chunyan Zhang <zhang.lyra@xxxxxxxxx>, Shawn Guo <shawnguo@xxxxxxxxxx>, Claudiu Beznea <claudiu.beznea@xxxxxxxxxxxxx>

In-reply-to: <ZKwtgwZtUUHGC+S3@smile.fi.intel.com>

Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

References: <20230710154932.68377-1-andriy.shevchenko@linux.intel.com> <20230710154932.68377-10-andriy.shevchenko@linux.intel.com> <20230710-doze-scared-9f0a2e1a9125-mkl@pengutronix.de> <ZKwtgwZtUUHGC+S3@smile.fi.intel.com>

On Mon, Jul 10, 2023 at 07:10:43PM +0300, Andy Shevchenko wrote:
> On Mon, Jul 10, 2023 at 05:59:55PM +0200, Marc Kleine-Budde wrote:
> > On 10.07.2023 18:49:26, Andy Shevchenko wrote:

...

> > > +	struct spi_transfer	t[];
> > 
> > You might want to use the DECLARE_FLEX_ARRAY helper here.
> 
> Technically, yes, semantically documentation [1] disagrees with

"and [2]"

> you, so I leave it as is.
> 
> [1]: Documentation/process/deprecated.rst:269

[2]: Documentation/process/deprecated.rst:350

-- 
With Best Regards,
Andy Shevchenko