On Thu, 29 Jun 2023 15:43:05 +0200, Jonas Gorski wrote: > If neither a "hif_mspi" nor "mspi" resource is present, the driver will > just early exit in probe but still return success. Apart from not doing > anything meaningful, this would then also lead to a null pointer access > on removal, as platform_get_drvdata() would return NULL, which it would > then try to dereferce when trying to unregister the spi master. > > Fix this by unconditionally calling devm_ioremap_resource(), as it can > handle a NULL res and will then return a viable ERR_PTR() if we get one. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next Thanks! [1/1] spi: bcm-qspi: return error if neither hif_mspi nor mspi is available commit: 7c1f23ad34fcdace50275a6aa1e1969b41c6233f All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark