Hi,
On 6/27/23 15:39, Krzysztof Kozlowski wrote:
On 27/06/2023 14:39, Valentin Caron wrote:
STM32 SPI driver is not capable to handle device mode with stm32f4 soc.
Stop probing if this case happens, and print an error with involved
compatible.
...
static const struct of_device_id stm32_spi_of_match[] = {
@@ -1798,8 +1802,16 @@ static int stm32_spi_probe(struct platform_device *pdev)
struct device_node *np = pdev->dev.of_node;
bool device_mode;
int ret;
+ const char *compatible =
+ of_match_device(pdev->dev.driver->of_match_table, &pdev->dev)->compatible;
The goal was to replace it, so drop it.
Is is still needed for dev_err, so I can't
> dev_err(&pdev->dev, "spi-slave not yet supported with %s\n",
compatible);
+ const struct stm32_spi_cfg *cfg = (const struct stm32_spi_cfg *)
Why do you need the cast? To drop the const? Are you sure it is really
needed?
Effectively, this cast is useless, I will drop it.
+ of_device_get_match_data(&pdev->dev);
Best regards,
Krzysztof
Thanks,
Valentin
